i modified the RNG to always generate lengths that are multiples of 3

I think there's an issue with testcases. Description says Each day is made up of morning, afternoon, and evening, so every three values in the array is a full day. But it says nothing about how to handle cases where the length of weather is not multiple of 3?

I just added clarification to the description. Hopefully it will help people understand the objective of the kata.

@isimon I thought this was really a good Kata but lots of people seem to struggle to understand it, and now the "satisfaction" rating is suffering because they are voting it down. Please consider some of the suggestions for improving the description so it gets the rating it deserved!

@dinglemouse
Thanks for the explanation. I noticed the sections rule but couldn't figure out what the purpose was, as it isn't clear from the examples what the significance is or what a day is in terms of the array.

To be more clear the description should say something along the lines of:

• "A day is made up of morning, afternoon, and evening (every 3 values in the array is a full day)" - then followed by the other rules, perhaps nicely formatted.
• When it rains or there is a thunderstorm he takes his umbrella out of his backpack and when it stops raining he puts it back.
• Every day starts with his umbrella in his backpack.

How many times does Joe take his umbrella out of his backpack?

You will receive an array of weather conditions, possible weather conditions are sunny, cloudy, rainy and thunderstorm.

RTFM

His day is divided into three sections the morning, afternoon, and evening

and

Every day starts with his umbrella in his backpack

So (your first example)...

Day 1

• morning: rainy -0+1=1
• afternoon: rainy - do nothing (he already has the umbrella out)
• evening: thunderstorm - do nothing (he already has the umbrella out)

Day 2

• morning: rainy - 1+1=2
• afternoon: rainy - do nothing (he already has the umbrella out)
• evening: cloudy - put umbrella back in pack

result = 2, expected = 2.

QED

Thanks bdupau.

@isimon even if he needs the umbrella during a thunderstorm, the examples are still unclear(to me at least):
First example:
rainy - OUT (1)
rainy - DO NOTHING
thunderstorm - DO NOTHING
rainy - DO NOTHING
rainy - DO NOTHING
cloudy - IN
= 1, expected 2
Even if lets say he puts it back at the end of a thunderstorm no matter what, it still doesn't work for test cases.

4th sample test:
rainy - OUT (1)
cloudy - IN
thunderstorm - OUT IN (2)
sunny - DO NOTHING
cloudy - DO NOTHING
rainy - OUT (3)
rainy - DO NOTHING (3)
cloudy - IN
sunny - DO NOTHING
= 3, expected 4.

Maybe I'm missing something, but I don't see how this can work from what we have.

Yes. I'll add that to the description.

So does a thunderstorm require the ranger to take out his umbrella? It's unclear from the two examples.

Added some random tests

Sample tests should be okay now.

But random tests is still missing ;-)

• Sample test is not runnable
• Needs Random Tests.