• No random tests (must also generate cases below)

• Missing fixed, sample tests for valid cases below:

  • ########## ext. # (3-digit areacode + 3-digit local3 + 4-digit last4 + extension)
    --> aF[}2654871290D~]:gF;X012345

  • Above case with leading 1 --> wV: 15754437619At,xfD90 (Note: 1575 with leading 1)

  • 1(###) ###-#### (1 followed immediately by 3-digit areacode + 3-digit local3 + 4-digit last4)

    --> a1234-567AbCd8901~:)SD

  • (###) ####### ext. # (3-digit areacode + 7-digit combined (3-digit local3 + 4-digit last4) + extension)

    --> !046f*S;b J2634114 extensio91243445445

  • Above case with leading 1 --> !1046f*S;b J2634114 extensio91243445445 (Note 1046 instead of 046)

  • (###)### #### ext. # (6-digit combined (3-digit areacode + 3-digit local3) + 4-digit last4 + extension) --> 254780gR]}\~fdn dA1234zyXtdfd01234567

  • Above case with leading 1 --> 1254780gR]}\~fdn dA1234zyXtdfd01234567 (Note 1254780 instead of 254780)

Diagonal lines are tested, but the line drawing algorithm is not specified. There are at least several possible line drawing algorithms.

JavaScript fork Cleaning up description adding Voiles issue and updating to mocha test

Does this kata require any specific node.js functionality?

• Should explicitly mention that coordinates given will always be valid

• Should also mention that points constituting towards diagonal or not fully-straight lines will be tested

• Node 18. and chai assertions should be used

Otherwise, a good kata!

I think the syncpromise's api should describe more rich.

Needs sample test(s) =/

Lots of required behaviours are in the actual tests instead of in the descriptions/example tests, especially about how the then and catch calls should be done.

There are way more stuff in the actual tests and second example in the descriptions than in the sample tests and what's described.

Please clarify them in the descriptions. Bashing against the tests to see all the edge cases is not a very good idea.

It would help a lot if you stated what line drawing algorithim you used to generate these tests