Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
not a kata issue , CW bug (some solutions despite being invalidated will not display as such)
Added
Regular Expressions
Tag.65 terms? precalculating.
JavaScript
What language?
There is no issue. Your have to code the make_lazy function to return something else to avoid the issue.
This comment is hidden because it contains spoiler information about the solution
Varveyn thx for explaining:) I have found this kata hard:)
This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution
I don't think that the runtime can be significantly improved. The algorithm is already linear with respect to the size of the input string and unless there are restrictions on the nesting, number of brackets, ... every char needs to be processed.
So the only room for improvement would be to minimize the number of operations needed for each char. As far as I know python lists are optimized for fast append() and pop(), so no possible improvement for the stack. The remaining code seems pretty optimal. Looking at your solution the only 'obvious' improvement (since this is a python2 kata) would be to replace range with xrange, but in my tests
range
,xrange
andenumerate
all have a similar runtime. The differences are much smaller than the differences due to the load on the codewars servers. So for compatibility with python3 I would stick withrange
.Hi kevin.du. I made 20 attempts without problems with my code in Python and all passed. I checked your code and many times don't reach the 145 tests. You should optimize it. Do not forget that the lists may have many duplicates. Thanks for the duplicates.
Marking as resolved since the python tests seem tuned enough now.
They are failing because you're most likely modifying the list. Check this SO answer out
Also there are a couple of other comments posted above regarding the same problem your facing, you might find them helpful.
Random tests are failing now. largest two numbers product is being compared with largest second and third numbers product
Loading more items...