Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Good kata but tests don't actually test for the requirement that when there are 2 words with max length, the last instance should be returned
Urgh silly mistake - fixed!
This comment is hidden because it contains spoiler information about the solution
Oops, you are right! Fixed now :)
Test cases are not working as clearly incorrect solutions are passing
No, I definitely need someone to critique my code! And yes, definitely - I'd used the comparing to string method as bit of a quick fix.
I've refactored my code to make it slightly better (above) but I'm realising that there is probably an even more efficient method so I will come back to it properly. Thanks as always :)
Fun kata!
Thank you!
The fact that this solution can pass is indicative of the fact that your tests are severely lacking, if not entirely non-existent! Please add more basic tests and if possible random tests as well.
No problem :)
Done, thanks :)
I've edited the description to make this clear just in case.
Both approved - thanks!
Thank you!
Done! Just added
1215and a couple other more cases into the basic tests for Ruby/JS too.Loading more items...