I did not think in that option. XD

I think in the old Python test framework, the files were simply concatenated together, making top level solution functions easy to abuse, hence the requirement. In the current test framework the files are kept seperate, so I don't think it is a concern anymore.

But regardless, just in case, I have moved the solution inside the test function.

Every kata and translation I have published had to be that way or never accepted.

I don't think it is necessary, users cannot import anything from the test file due to circular import, unless there is some other kind of "hack" I am not thinking of?

I think solution function should be inside tests

@test.describe("Test")
def test_group():
  def solution(): 
    ....

Forked to fix merge issue.

I see, that makes sense, thanks a lot!

Thank you! Pushing and popping rsi when allocating space for new string is essential because this register holds address of input string and malloc clears its value.

Beautiful code, but why is 'push rsi' and immediately afterwards 'pop rsi' is necessary?