Fixed.
I'm pretty sure it's the same in
In Python, the Compiler class has 2 pass1 method and no pass2 method.
Same for PHP, I expected to return a JSON string from pass1, but an array was expected.
Parameters are in the wrong order in PHPUnit tests: assertEquals takes $expected then $actual. So failure messages are missleading.
It's clever and short code have some advantages, but this is certainly not Best Practices. I don't understand why it has been voted as it.
Loading collection data...
Fixed.
I'm pretty sure it's the same in
In Python, the Compiler class has 2 pass1 method and no pass2 method.
Same for PHP, I expected to return a JSON string from pass1, but an array was expected.
Parameters are in the wrong order in PHPUnit tests: assertEquals takes $expected then $actual. So failure messages are missleading.
It's clever and short code have some advantages, but this is certainly not Best Practices. I don't understand why it has been voted as it.