Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Random test sometimes generates race condition like this:
At
t=270ms
the function is called while it's time for a break. What is the expected behaviour here? If there's a specific desired behaviour then it should be tested in sample test; if not then it shouldn't be generated at all.Given the backstory, I think it's quite defensible to start aiming for a break as soon as you clock in. ( Dog knows I do! )
It may not be what you want for the task, but the task is defined in light of the backstory!
Yes I think so
Better?
Yes I did that one first when I misunderstood the task slightly, the name of the function
startWorking
to me implied that we should already start the timer.I think the
might be more confusing than it is helpful. Something more direct like "The timer should not start until the returned function is called" might be better. (There are probably even better ways to say that)
There is always work to do (it's called at least once).
I like to avoid that you do a break without working.
Shouldn't that be "It is possible .." ?
Thx Kacarott,
I checked your results and updated the tests and description to avoid this solution:
https://www.codewars.com/kata/reviews/60a24cfbf2b4d60001148fe2/groups/60a3518d3238e20001424f96
This should not be possible, but I understand why you did this 👍.
Added:
I've done my part. While pretty easy, it is also very unique and I think many JS beginners will appreciate it.
:), I'm happy with the result of my first kata.
Now I know what to expect next time.
I hope it won't be similar to Implement Debounce which is open for 4 years.
That's just not how it works. Sorry. Incentive to get everything completely right first time! ( I know, sometimes that's just impossible. )
I added this part:
Alright, I hope they will update their votes soon. Wouldn't it make sense to reset the rating after big changes?
Here's hoping raters will come back and update their vote .. or it might be quite a while before the legacy "meh" votes get outnumbered by newer, more positive ones.
Looks nice. Lots of things I don't really understand happening - I'm not big on async stuff.
Testing takes quite a while. You might want to warn solvers about that. If you can do testing in, say, 4 seconds, instead of 10, that'd be nice ( but I understand this stuff will always take time ).
Tests are refactored and random tests are added.
Wdyt?
Thx for your feedback, it's very helpful.
Loading more items...