Yes, did it in another fork again

thanks for the fork

could you make all of the tests suite functions static ? this prevents namespace pollution, and users trying to cheat / mess with the tests

Okay :D So much to learn..
I don't know if i did the right thing, couldn't find the edit button that let me to the old version. So i just did a new fork of the translation. It's waiting for approval.

you edited the translation, this has no effect on the kata once it has already been approved ;-)
you can edit the kata's C version directly with the 'Edit' button when viewing the kata

Thanks for this Advice. I Fixed it :)

@lnx1_1
Criterion's default error messages are not very helpful :

The expression (isAValidMessage(buff)) == (isValid) is false.

How do I debug my code with this kind of message ?

You need to override it by supplying an extra argument to the assertion. Criterion assertions can take an optional printf format string parameter and corresponding arguments :

cr_assert_eq(is_valid_msg("abc"), false, "for string %s, expected %s", "abc", "false");

to avoid code duplication, assertions are usually wrapped in a function :

void do_test (const char *msg, bool expected)
{
  bool actual = validate(msg);
  cr_assert_eq(actual, expected,
    "expected %s for '%s'",
    expected ? "true" : "false", msg
  );
}

Could you please edit the C version to do this ?

Oh, you're right! Didn't see that :)

Had the random Test in "Sample Test".. fixed it now

PLease add random test cases

Because he uses it outside the loop then. Try and see what happens, much better than ask for explanations ;)