Ad
  • Custom User Avatar

    I, clearly, do have a lot to learn! Thanks a lot for taking the time to feedback. I will have a read of the docs and try and improve my kata.

    Thank you both for the links, that's really helpful!

  • Custom User Avatar
  • Custom User Avatar
  • Custom User Avatar

    Please read documentation. There's a wealth of knowledge and wisdom in there I'm not going to reproduce for you.

    Please read initial code on other kata ( you don't even have to solve them for that ), and see how it conforms to what is in the docs on initial solutions ( or sometimes, it doesn't. and sometimes you can find Issues on existing kata that "initial code doesn't compile" ).

    Being new, you have a lot to learn about creating kata; being old ( and grumpy ), I will not be reading back the docs to you today.

    Please understand creating kata is of an entirely different order than solving kata. There is little room for error. Creating a kata without random tests is a massive and entirely preventable error. Read the docs!

  • Custom User Avatar

    Hey thanks for trying out my first kata!

    Apologies but I am very new to all this, what do you mean by this?

  • Custom User Avatar

    There do not appear to be specific tests for solution's handling of capitalisation, something like ("A b","C a") -> ["a"]. Same for allowed and disallowed punctuation, I think.

    Also, having running phrases is nice, but for debugging, starting with simpler, artificial inputs is better.

    You need lots more tests if you want to reliably discern conforming from non-conforming solutions.

  • Custom User Avatar

    No random tests.

  • Custom User Avatar

    Initial code should compile.

    Also, giving inputs and output, if possible with type hints, would be nice.

    Something like function solution(string0,string1) { return [ "word" ]; }.