Ad
  • Custom User Avatar

    Unfortunately, adding a couple more of fixed tests is not a complete solution, because fixed tests can be easily hardcoded. While a fixed test will point you to a flaw in your solution, it will not force you to fix it, but can be satisfied just by hardcoding it. The solution would be to add fixed tests and fix random tests so they are guaranteed to generate inputs of all kinds. And there is already many issues about this (I counted 7 issues related to insufficient tests).

    You can propose a fork with more fixed tests, but this is only a partial solution. If you created a fork with good random generators for all types of expected results, it would be great.

  • Custom User Avatar

    Adding a couple more of fixed tests isn't the solution.

    Yes, it is. I passed the kata without knowing I have an error. Only looking at other solutions made me realise I misunderstood the assignment (at first I assumed that 1 and 2 over interesting number should be classified as almost interesting).

    Palindrome error I made (my code worked for odd length input but didnt for even. e.g. 15751 was classified correctly but 1551 was not). This is exactly what edge case tests are for. For palindrome, one test case for even length and one for odd would catch that.

  • Custom User Avatar

    The random tests in Python don't cover much and their value isn't random afaik. There is an open issue about that saying there are no random tests, closing this one. Adding a couple more of fixed tests isn't the solution. I guess a much wider range should be checked the question is how.

  • Custom User Avatar

    Two issues with attempts:

    1. returning 0 for 1221 (even number of digits in a palindrome) passes the kata, should require 2
    2. returning 1 for 1235 (1 or 2 bigger then interesting given number 1234 -> 1235) passes the kata, should only allow 0

    Those are two bugs I had in my initial solution that were not checked in an attempt. Having more simple test for those edge cases would be helpful.

    #python

  • Custom User Avatar

    finally solved it and each time i look at all the papers i used and how complex is my code i think i am a freaking genius , tht s all i ve to say

  • Custom User Avatar

    This is specified in the description:

    NOTE 2: The 0x0 (empty matrix) is represented as en empty array inside an array [[]].

  • Custom User Avatar

    Given an n x n array,

    Attempt gives [[]] which is not n x n (it is 0 x 1 array)

    No tests with n x m array. Please fix description

  • Custom User Avatar

    I don't think so. the group by conditions are different - there is no reusable logic here

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution