Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Tests are woefully inadequate, they don't even check if the methods would call other relevant methods (e.g unsubscribing a runway from a
ATCClient
should unsubscribe it from the runway).No random tests.
This is not really a factory pattern, what the author wants is a class whose sole purpose is doing a table look-up, which is an OOP misuse if anything. The other requirements are either duplicates at this point (reverse a string), or they're plain worthless (wrap a method in a function, add an attribute to a class).
Also, there're no random tests.
Task is poorly explained:
B
oriB
? One of them has multiplier of 1024 and the other is 1000The output should be a string with following units: B, KB, MB, GB, TB, PB
What do these units mean? How do they relate to each other?5.50 MB
and not5.5 MB
)Also, consider specifying in the text of description (and not just in test cases) what behaviour do you expect and what fields are required for each class. Currently, you do not specify explicitly what happens to .runwayStatus in client objects after they unsubscribe. Also, judging from your own code, clients behave differently: GroundServiceClient just changes .runwayStatus to empty string, while ATCClient deletes the whole runway - so trying to access runwayStatus will probably cause an exception. This is not intuitive, you should specify this somewhere.
This is a very nice kata! I was looking for something that helps exploring design patterns.
However, I believe test cases could be more detailed. Currently, example test cases are just the same as final test cases. I think it is a good idea to add some more, checking different things.
Typescript translation kumited! Please Accept :D