In general, no it's not good practice to put everything on one line. In this case, it's fine. This is a very pythonic solution, this would be just fine as is in almost any codebase (depending on usecase).

is it good practice to put everything in one line? it's elegant, but may get hard to read, once things get complicated.

I had exactly the same solution!

Very good!

cool, although it's not as straightforward

Cara, gostei muito da sua solução.
Sinceramente me fez pensar em como eu ainda tenho que melhorar, porque a minha resposta teve algumas linhas a mais, mas isso só serve de incentivo para continuar evoluindo

😎it`s me

a

I don't know how that would be more time efficient since the time complexity is O(n * c) where c is the number of vowels. Ie it has to loop through the entire string for every value because of replace method. The given solution is O(n) complexity.

and here I assumed I couldn't just sort a string...

Dude, why your code return "<generator object dis_trol at 0x00000186174DBB90>"
instead of a string

Same. Best platform for learning imo. Mad I didn't sign up sooner.