Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
There is no instruction for what to do when
offset >= depth
.Also no example and sample test for the above case
Unnecessary logs should be replaced with assertion messages and
it
blockstests should be updated to node 12
not enough random tests
errors should be included in the random scenarii
the ref solution is incorrect, because subject to floating point errors:
There are only 3 random tests per run (which is not enough, should be something like 100), and the test are making the old "duplicate test case generation code n times instead of putting it in a loop" mistake again.
The tests does not check if the thing thrown is actually according to the descriptions.
When the number is negative, the test is asking to round up, not down.
-3000.567 rounded down is -3000.6, not -3000.5
Needs random test cases