Ad
  • Custom User Avatar
    • There is no instruction for what to do when offset >= depth.

    • Also no example and sample test for the above case

    • Unnecessary logs should be replaced with assertion messages and it blocks

  • Custom User Avatar
    • tests should be updated to node 12

    • not enough random tests

    • errors should be included in the random scenarii

    • the ref solution is incorrect, because subject to floating point errors:

      [Number: 677253.527192] 8
      Should work with random numbers between 0.0000001 and 9999999.9999999 
      Expected: '677253.52719199', instead got: '677253.52719200'
      
  • Custom User Avatar

    There are only 3 random tests per run (which is not enough, should be something like 100), and the test are making the old "duplicate test case generation code n times instead of putting it in a loop" mistake again.

  • Custom User Avatar

    The tests does not check if the thing thrown is actually according to the descriptions.

  • Custom User Avatar

    When the number is negative, the test is asking to round up, not down.

    -3000.567 rounded down is -3000.6, not -3000.5

  • Custom User Avatar

    Needs random test cases