Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Fixed it up.
I was having the same thoughts. I'm leaning toward making it more in line with
ArrayCurrently, it returns back an empty array and has no effect. It might be a good idea to bring this inline with Array.prototype and have it return
undefined. Thoughts?For this version of the kata, no. I'm going to be posting an advanced version of this soon where it will be different.
Not an issue.
Not an issue.
This is fixed.
This is fixed.
This is fixed.
This is fixed.
Right, that makes sense. I'll ammend this when I get a chance.
I wanted to leave
popremoving the last added element for part 2 of this Kata, same forshiftand first added element.Yea, the reason they're named that was to mimick the Array.prototype api. I appreciate the constructive critisim but could do without the personal attacks. Thanks though.
Thanks for the feedback, I'll fix these issues sometime tomorrow.
Array.isArray is based on Symbol.species, which is no longer hidden in implementation. But I get what you're saying. I came up with this earlier today and I know it needs more work to be complete. Thanks for the feedback!