Ad
  • Default User Avatar

    I changed the description according to your first comment.

    Can you be more specific about the 2nd one? I do not understand what you are referring to.

  • Custom User Avatar

    Ok, so there are some problems with this kata:

    1. In the description you say that only "last cards" are counted if the amount of cards is odd — BUT how about the cases where there are more counters than ordinaries? Also, EACH card which don't have a pair should be counted, not LAST one.
    2. In Python tests, there are strings like "{} should be {}" and such. Maybe something should be inserted into the brackets?

    Maybe the second issue can be tolerated, but the first one makes the kata description misleading and contradicting with the Wikipedia data + tests, therefore, I do believe this kata should have not a misleading description (like, you need to make pairs of counter+ordinary and ordinary+ordinary and then add the scores of the cards which don't have any pairs or smth like that). =/

  • Default User Avatar

    That's weird. I cannot reproduce this issue.

    The expected score for random tests is computed with my solution as reference : https://www.codewars.com/kata/reviews/5868f6c57ba2f53c2100001e/groups/5868f6c57ba2f53c21000020

    For the given example, it computes 55.

  • Custom User Avatar

    Something seems wrong with this Kata in Haskell. A 78 card hand should get a score of 55, but the Random tests are expecting it to have a large negative score.

    Example:

    -- >> tarotScore "SC15DQ0904D7D41703H3CQ0607H6051612HKH7H2SKHCHQ20D3C9CJS7D5DCS5D6C8H9S41014C7S0SQC4S2H419H001D1C3D0S3D9CKC1DJCCS821S90213C0C5S618S1D8H5H8HJ08C6DKSJ11H100C2D2"
    -- (-99) % 2

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    but I don't think this is memorized

  • Default User Avatar

    From wikipedia: this is the true score (not a simplification); the pairing method simply makes it easier to manually count points when ordinary > non-ordinary. (I don't know the game.)

    https://en.wikipedia.org/wiki/French_Tarot#Scoring

    Maybe tests are right and description is wrong.

  • Custom User Avatar
    // every card is worth half a point
    // jacks / knights / queens / kings & oudlers are _additionally_ worth 1 / 2 / 3 / 4 points
    

    This simplification is just wrong.

  • Custom User Avatar
    SJ
    
    Expected: -54.5, instead got: -56
    

    ??? Shouldn't only ordinary cards be counted half when alone?

  • Custom User Avatar

    Random tests expect the wrong results:

    SJDJD9DQ
    
    Expected: -49, instead got: -52
    

    There are not enough ordinary to match all 3 queens and jacks, so why -49?

  • Default User Avatar
  • Custom User Avatar

    Re-raised this issue because lots of languages do not have random tests.

  • Custom User Avatar
  • Loading more items...