Ad
  • Default User Avatar

    Nice kata to practice regex skill. I'd suggest enabling Node v12.x because useful regex features such as named grouping are not supported in Node v8.x.

  • Custom User Avatar

    There should be much more thorough testing with invalid phone numbers, as currently it's possible to pass with incomplete input validation.

  • Custom User Avatar

    From the description it is unclear if it is allowed for "separators" to be mixed within the same phone number.

    • The examples in the description don't cover this point.

    • The first sample test imply they can be mixed.

    • But then the final tests don't seem ever to test for mix of separators.

    Suggest clarifying this in the description.