Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Rejected by someone
this does not seem to be camelCase ? the other languages expect
"UpperCase"
Rejected by someone for unknown reason
bruh
upgraded version
approved
approved
Yes, I know that, I was just wondering whether it's worth fixing it in one PHP version only.
Funny enough, now that I tested around with a changed version of the random test, I noticed it did not actually work anyway, at all.
The test method providing the real solution was called without
$this
, and named the same as the real solution (except character case) - which seemed to have called the real solution twice, for$expected
and$actual
, making the test effectively useless.replying to your comment below (for the purpose of notification triggerment)
the usage of
echo
might pollute the namespace, same goes to other languages and it is general advice to not use print statements anywhere when generating test cases.You can put the echoed text in the
$this->assertSame
part as a 3rd parameter for assertion messages FYI!Can you add headers as requested in the update list in the meantime??
While I would technically agree with that, and potentially drop that echo completely without replacement, this has not been added in this PHP8 upgrade translation. If it were to be dropped/replaced, I guess it should be dropped in all versions?
Instead of using
echo
, can you add assertion messages directly inassertSame
?? (And the assertion message should not be the random test counter, which provides no info to solvers whatsoever :-)Approved.
Translated to PHP
Go translation
Loading more items...