Ad
  • Custom User Avatar

    The original author doesn't seem to be around, but I've forked this translation such that

    • aspect_ratio now returns a Tuple[int, int] instead of a List[int]. The justification for this is that aspect_ratio alwasy returns a pair of two ints, instead of a list of an unknown amount of ints.
    • Changed the format of the test headers slightly
    • Created a random instance for tests to use before importing the user solution so that users cannot modify the random instance.
  • Custom User Avatar

    Almost done, thumbs up on the edge case and small & large input cases, but still needs a big modfication

    • Don't alias aspect_ratio as user_solution, it's confusing

    and some minor modifications :) ~~

    • Remove the multiple spaces after from solution import... and leave one space will do

    • Remove the performance testing & correctness testing in it block as this is not a performance kata

    • Remove the return [x, y] in the initial solution as that is misleading (at least ~~)

  • Custom User Avatar

    Thank you for the link!

    • I've added a small and large random tests (100)
    • and read through the new framework and tried to update the Tests

    I'm still new to codewars tests so please let me know if I messed something up very badly!

  • Custom User Avatar
    • Increase number of random tests to 100

    • Python new test framework should be used -> refer this

  • Custom User Avatar

    First translation attempt. Just tried to update to v2 testing framework and make things a little more PEP8.

    Please let me know if there's anything I could fix!