Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Thanks for taking the time to review:
Float
should be enough to handle the value of a car. I'm not going to push back if you thinkcar
method needs to recieve aDouble
, although I don't think double precision is needed in this particular case.String
- which btw I don't particularly like - if is legit to change the haskell translation to returnFloat
orDouble
I'd be more than eager to do implement the change.Test.QuickCheck
, I'll remove it.Haskell translation kumited.
Test harness for haskelll has an issue as reported below.
If there's a way to contribute code to have the issue fixed I don't mind helping to have it fixed.
Thanks for the link!
This comment is hidden because it contains spoiler information about the solution
The test suite should include tests for
null
collection
used in the constructor : many of the solutions accepted do not protect themselves against null pointer exception when callingcollection.size()
;)Can I suggest to add to the kata description details on how
itemsPerPage
== 0 should be dealt with or otherwise state clearly that this scenario can be completely ignored.Otherwise a very good kata - in particular like the object oriented approach as oposed to that many katas based on a single function to be solved.
I'd suggest to add some edge test cases to this kata:
I already implemented those for java in my submission. Pasting them here in case you want to make use of them:
The ternary operator is redundant in this case
This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution