dirty code practices

bealtiful

Oh wow. This looks like my first kata was a little bit too predictable, thanks to u man

Good observation, i hadn't noticed, i made the change

In random tests you sholdn't recareate object Battle before each call of play_turn.

As it has been written before me, kata should teach something, give knowledge. this kata only makes me confused, turning me into the protagonist of the movie "A Beautiful Mind" sufficient justification for the issue tag?

Try some examples on paper.

because despite having its dangers, the solution is beautiful to see, in the context of codewars, this type of solution comes out ahead... multiple 'ifs' are sometimes not very elegant..

Thank you

Good :) Nice kata

Got it, I added a description about that part to make things clearer, thanks for your feedback.

For the first point; it means when does someone's buff disappear, after their own attack, after the adversary attacks them, or just after each round? For instance, if I buff, then my adversary buffs, does their buff mean that my buff is now gone, or not, since they did not attack yet .. stuff like this

I changed the description of the abilities to remove the ambiguity, I agree with you on that part.

But, I thought I had made it clear how the buffs work in the rules and considerations section, in addition to the examples. I didn't quite understand what you meant by that 'does not count as an "attack" of the opponent', are you talking about whether a buff can influence the effect of another buff used sequentially? Well, there is no such interaction, this does not work as an opponent attack, maybe I can describe it better in the description.

obs.: My English is not very good, I am not a native speaker, if I interpreted your problem wrong please correct me.

• It's not clear from description when buffs get deactivated or decreased. It appears when the opponent does a buff himself after your own buff, this does not count as an "attack" of the opponent, and thus the own buff does not get deactivated or decreased.
• There are more ambiguous terms such as "Inflicts 90 points of damage.", this isn't true, it's better to state "Attacks with a power of 90 points". The damage is not necessarely 90 points, as it gets calculated based on the power of the adversary and the current buffs of self.

I think my solution shouldn't have passed, it failed the first time, and when I tried again it passed the random tests.