Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
because despite having its dangers, the solution is beautiful to see, in the context of codewars, this type of solution comes out ahead... multiple 'ifs' are sometimes not very elegant..
Thank you
Good :) Nice kata
Got it, I added a description about that part to make things clearer, thanks for your feedback.
For the first point; it means when does someone's buff disappear, after their own attack, after the adversary attacks them, or just after each round? For instance, if I buff, then my adversary buffs, does their buff mean that my buff is now gone, or not, since they did not attack yet .. stuff like this
I changed the description of the abilities to remove the ambiguity, I agree with you on that part.
But, I thought I had made it clear how the buffs work in the rules and considerations section, in addition to the examples. I didn't quite understand what you meant by that 'does not count as an "attack" of the opponent', are you talking about whether a buff can influence the effect of another buff used sequentially? Well, there is no such interaction, this does not work as an opponent attack, maybe I can describe it better in the description.
obs.: My English is not very good, I am not a native speaker, if I interpreted your problem wrong please correct me.
I think my solution shouldn't have passed, it failed the first time, and when I tried again it passed the random tests.
I also missed that in the description
clean code at its best
the best
This part could be clarified. I interpreted this to mean that the pieces cannot be rotated, but that's not the case.
For sample test
test.assert_equals(calc_max(150,30,120,178), 4)
: how can you fit any pieces if width of a piece is larger than width of the area?you made very important considerations, and i will make the changes, in the case of the variable names h, w, H, W, the simplicity of understanding is worth it, for now I will keep them like this, the rest of the changes I will make thank you for your review, so much.
Some further remarks, but mostly not as serious as the above ones:
#random
or in main thread of#help-author
of CW Discord).w
vsW
andh
vsH
. I get what they mean, but I wonder if something liketileWidth
andtotalWidth
wouldnt be better, or something similar.Basic Test Cases
does not show inputs. I am not sure if the section is even needed, because you have all the other "specific" sectionsYour answer for w=2352, h=4404, W=9164, H=2624 is incorrect
calc_max_test
and make it local to therandom_tests
. It does not need to be at module top level.When you feel that you fixed the problems, feel free to mark this issue as resolved, and republish for further review if you want.
Loading more items...