approved

Approved by someone.

great point re: dotest function not giving good error messages.

question: will trivial forks that only enable nim 1.6 (e.g. s/random/rand/g) not be accepted?

I don't see what your fork brings except Nim 1.6. Furthermore:

• your initial solution doesn't compile but it should
• the "dotest" function is wrongly placed (as is mine in that kata)
  so any false solution passes the tests and gives for example:

"Passed: 2 Failed: 0 Exit Code: 1
Test Results:
printerError

fixed tests
random tests
Completed in 7.5338ms

STDERR
Error: execution of an external program failed: '/workspace/tests '"

The kata doesn't succeed but people with false solutions don't understand what happens since they get "Passed: 2, Failed: 0" but no success.
I had to modify many of my Nim kata for that reason but unfortunately I didn't have enough time to do it for all...

It is often better to ask before forking or updating.

I hope I have clearly explained my reasons:-)

Oh, now that's weird. I literally googled this issue earlier and I found that exact post, only I think it was on Medium and didn't have any name attached. Weird that it was you haha.

Approved!

[Being nitpicky here]

Try to be more consistent with indentation (the return in your solution), wrap things into a Test.describe() and possibly try to figure out how to generate half the tests as positive, otherwise the random ones will be most likely all False.

Feel free to give a look at my Ruby version to get an idea (it should be rather readable for a Pythonista too); cheers :)

You can wait for the author to approve it :-)

https://github.com/Codewars/codewars.com/issues/1111

:)

Fixed

True :-)