Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
This looks like a duplicate of the Basic Calculator kata.
approved
Java translation
This is the first time I'm writing a Java translation for a kata, so any feedback is welcome.
JavaScript (possibly others)
fixed / random tests
should have a test like (5, 5, '-') which should return the calculation of zero, otherwise incorrect solutions like this solution can pass the kataThis comment is hidden because it contains spoiler information about the solution
Approved.
This comment is hidden because it contains spoiler information about the solution
JS fork 🤖
mocha/chai
assertions +lodash
for randomnessFair enough, I'll try to replicate the python tests in js when I can.
this was fairly common among solutions I scrolled through, so, yes, this is now tested for
ahhhumm.. js? I don't have the js-fu to sniff out incorrect solutions at a glance especially with all the odd things js does and the existing tests are nearly non-existant considering that the kata sets out to mix types. its reference solution is using
isNaN
to do type checking which makes me want to send them a strongly worded dead tree letter. no I don't want to touch it.it's still easy to find slightly incorrect python solutions (especially if willing to go for pathological test cases) but mixing types is smelly anyway. I scratched my itch.
Approved, could you take a look at the two issues below too? I think you already addressed the second one.
Just the same, the "should be" wording is poor presentation and potentially misleading. The beginner solver doesn't know what to expect and has other things on their mind. A 8 kyu kata should not behave this way. (or any kyu really but whatever)
So I'm fixing the root cause of this and a couple other blemishes and some tests that I think were missing although I'm sure there are some more stuff to test if one sifts through solutions to find some wrong ones. Please approve my python fork
Not a kata issue, print the input values to debug your code.
Loading more items...