I'm passing by value here. So the data is copied into a new string and returned. This may be a best practice if you don't want to modify the original string. I would normally take a value like this by reference or use RVO but this looked like a fairly clean implementation. For its use case, passing by value is probably enough here.