Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Haha.
Still, no match for a noble effort XD.
Cool! Approved.
I indubitably agree.
Right, all primitives are immutible in JS. I guess what I meant is, don't modify or try to modify any of the input data (variables, array elements etc...) since traditionally Javascript allows us to do so. I intentionally declared my input arrays using
const
so an error would be thrown if a user tried.I appreciate your feedback!
Fixed.
I appreciate the feedback. I somehow never learned that without declaring them, the variables won't be scoped to the loop. As far as the second point, probably just using
bitmap[Number(vals[i])] = 1
would be my refactor in this case. Sort of implementing both simplified logic and cleaner type coersion.Oh duh! Fixed. Thank you.
This was extremely helpful feedback, thank you! Move all of the final tests into fixture and replaced .expect with .assertDeepEquals as suggested.
Thank you for the feedback! Refactored the sample and final tests using this method.
Updated the instructions to make this more clear.
Great kata! I'd love to know how you disabled prototype methods in your test environment.
Hmm...
...
Random test cases expected false when the input string is valid:
'bkngaojk.gif' - expected false, got true
'jrgigirh.alac' - expected false, got true
and so on...
Am I missing something or are these actually invalid inputs?
Loading more items...