You need to sign in or sign up before continuing.×
Ad
  • Custom User Avatar

    The kata is stuck at Node 8.

  • Custom User Avatar

    There are no random tests.

  • Custom User Avatar

    Design issue: Angular is already predefined and the tests expect the dependency graph to be cleared after angular.bootstrap for test reuse. But angular.bootstrap can only be used once anyway, so the kata is definitely not adhering to AngularJS standards.

    It should also be argued that Angular should be a class defined by the user, not in Preloaded, so we're not coming with our weird ways to keep track of dependencies in other global variables, and clearing the dependency graph by timing where one part of the test ends.

    (Speaking of which, currently when angular.module is called with dependencies it overwrites the existing dependency graph before doing validation. This is very unexpected; vaildation failure should not change the state of an object.)

  • Custom User Avatar

    The order of the dependencies in modules array after bootstrap is not specified.

  • Default User Avatar

    Good kata with one very minor issue - the "Angular" constructor is locked, which makes it confusing to try to add a new property (for tracking dependencies). It is easy to workaround but may be worth mentioning in the description.