Ad
  • Custom User Avatar
    • not enough tests
    • needs random tests
    • needs to test edge cases more precisly (especially about the order in which the "oddities" have to be resolved)
    • you didn't make clear how we're supposed to identify when 1 hour has to be deduced for lunch (not hard to get, yes, but that should be in the description)

    cheers

  • Custom User Avatar

    Hi,

    The rules are somewhat unspecified about this case:

    [['8:30', '17:30'],
    [],
    ['8:30', '13:30', '14:00'],
    ['8:00', '17:00'],
    ['8:30', '13:00', '15:00', '17:30']]
    

    you expect "... missed one day" while one could considere return the "odd" thing instead. => you have to tell how the check should be done:

    • return the first encountered error?
    • check for one specific kind first?