The ISSUE tag is reserved for critical flaws with the tests. 718 people have solved this Kata in JS before just fine, so, when in doubt, please use the QUESTION tag instead. As for your question, the code inside your loop needs correction. Instead of focusing on the complicated test that fails, focus on the other more simple test that the solution fails on: f: abcd s: dabcd returns abcd for you when it should return abcdabcd. This is a byproduct of the method you use to calculate indexInSecond.
Yes, the issue resutls from your code misunderstanding the task. The only overlap that this Kata is interested in is between the end of the first string and the start of the other. A string overlapping in the middle of the other doesn't count. As you've noticed, merge_strings('xabc', 'ab') is expected to return xabcab (since no overlap on the edges), and notxabc. Consult the Kata description further if in doubt
This comment is hidden because it contains spoiler information about the solution
bro, really nice job👏👏
resolved in this fork
Ok. Thanks for the advice. An take your time to let me know.
I tried with all cases and this the only one that fails.
But I will do what you suggest me.
The
ISSUEtag is reserved for critical flaws with the tests. 718 people have solved this Kata in JS before just fine, so, when in doubt, please use theQUESTIONtag instead. As for your question, the code inside your loop needs correction. Instead of focusing on the complicated test that fails, focus on the other more simple test that the solution fails on:f: abcd s: dabcdreturnsabcdfor you when it should returnabcdabcd. This is a byproduct of the method you use to calculateindexInSecond.Yes, the issue resutls from your code misunderstanding the task. The only overlap that this Kata is interested in is between the end of the first string and the start of the other. A string overlapping in the middle of the other doesn't count. As you've noticed,
merge_strings('xabc', 'ab')is expected to returnxabcab(since no overlap on the edges), and notxabc. Consult the Kata description further if in doubtThis comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution
Approved.
2 день решаю, не прохожу всего 6 тестов. И често, я как то не уверен, что эта ката подходит для 7 кю, мне кажется она сложней.
C# Translation
approved
Rust translate
Nice Kata! Took me two hours to solve this :)
I agree wholeheartedly. Nevertheless, the satisfaction rating is 54/116. It must be a puzzle and not an algo kata.
Loading more items...