Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
This kata doesn't satisfy basic kata requirements: spec is still unclear, test code is riddled with basic technical errors, only 7 fixed tests, and no random tests.
Kata author really should have a look at the kata authoring guideline.
Expected and actual values are flipped in the test assertion messages:
chai.config.truncateThreshold = 0;
is also missing in test code, which truncates inputs in assertion messages:Please describe elevator behavior more eplicitly. For example:
This way you don't have to resort to the test cases to find this out.
done (author is not really that active)
this is done
https://www.codewars.com/kumite/64318eadd4d3ea249d4801ea?sel=64318eadd4d3ea249d4801ea
should add character limit (2000 should be fine) to guard against hardcoding.
Nice kata. Thank you.
Fixed.
I think the issue is fixed, could you please verify?
It seems to be a bug, I'm not sure yet if it's a bug in the kata, or in setup of PHP on Codewars.
This comment is hidden because it contains spoiler information about the solution
Fixed
Good point fixed.
Random tests sometimes provide invalid input where
currentFloor
is outside the valid floor range, such asnew Elevator(46, 48, 27)
.Moreover, the constructor signature is
minFloor, maxFloor, currentFloor = 0.0
, which is very dangerous as0
is not always inside the valid floor range. Why not just make it mandatory?Loading more items...