Ad
  • Custom User Avatar

    But the description says Tested values are all between 0 and 100. Theres is no need to check for negative values or values greater than 100.

  • Custom User Avatar
  • Custom User Avatar

    I like the variant in the solution better, because if the average value is higher than 100 we will get a panic "entered unreachable code". And in the solution you propose we may not know about this error, because instead of panic we will get the result of F evaluation.

  • Custom User Avatar
  • Custom User Avatar

    Oh lovely, I didn't know you could do that with =n to make it inclusive.

  • Custom User Avatar
  • Custom User Avatar

    It doesn't really matter in this case because we only use u16 numbers.

  • Custom User Avatar

    89.5 is less than 90 so it should return 'B' but would go for unreachable!() in your code. Your ranges in B,C,D and F arms go to a whole number that is less than a first number in a previous arm.

  • Custom User Avatar

    It's about expectations.
    To cast a u32 to a char, you have to use char::from_u32(). This returns an option, making it explicit that the result may not be a valid unicode value, but when it does (result is Some(char), then you know it is what you expected it to be based on the value held by the u32. The types match. This simply isn't the case with an i32, where you have a 50% chance to get it catastrophically wrong. So, as a programmer, you aren't allowed to simply cast signed to char that way. But it's your choice to "make a detour via u32 or smaller", because then it should be clear to you that casting a signed value to an unsigned value will yield "weird" results.
    Note that when casting to u8 first, there is no possibility that you'll get an invalid unicode value because the entirety of 0-255 is valid, hence you're allowed to directly cast u8 as char

  • Custom User Avatar

    Yeah, i see your point. But could one not argue that if u32 as char could panic depending on the u32 value, why is it any different than knowing the risk of a i32 panicking in the case of a -ve value for example?

  • Custom User Avatar

    char may not be what you think it is; it does not make sense to allow casting from a signed integer to a unicode scalar value. However, a signed integer can be cast to an unsigned of greater or equal size by simply interpreting the bits accordingly. Any unsigned up to 32bits can then be cast technically into a char, however it might not map into the valid unicode range and panic, but at least as far as the type system is concerned it's possible to do.

  • Custom User Avatar

    Had no idea you could chain casts like that – very nice! (though it seems redundant to not allow i32 as char ?)

  • Custom User Avatar

    Inserting at 0 is not very efficient as it copies the whole string every time. It is better to simply push (to a Vec for example) and reverse everything at the end.