Ad
  • Default User Avatar

    I expected you to work with quarter of circle of radius 1, centered at 0, 0 )). Probably, it`s gonna be the same result

  • Default User Avatar

    Well, creating this kata I was targeting to create a puzzle. If I tell that given floats should be considered as point on cortesian plane and we should include/exclude points exectly on the circle of radius 1, the puzzle will be spoiled. However, you have a point that right know I demand more or less exact method I was using for solving, which is not good. Directly asking for some approximation is not also good idea, because just returning a float in given boundaries will pass. Kata needs some improvements

  • Default User Avatar

    Hi!

    Thank you for your reply. You are right, they are the same. Probably, I should unpublish my

  • Default User Avatar

    Result format in random tests and sample tests are different. For example, in sample tests accepted answer is ${n} day(s), but in random is ${n} days. Also the white space between Today! and Finally!

  • Default User Avatar

    Also had this problem.
    This kata seems to want people to be sorted in the following order: by first name, if they`re equal, by last name, if they`re equal, by adress. I didn`t find it mentioned in the description.

  • Default User Avatar

    Great kata overall! However, I believe that input like £1p should return 'Invalid input - enter a positive amount of money'. Since £ at the beggining means we are dealing with pounds and "p" at the and means pennies, this input become really tricky because we don`t know which sign is more important in this particular case. I would suggest considering as valid only "£1", "£1.0p" or "1p" as far as here will be no space for misunderstanding.

  • Default User Avatar

    I think I might understand what you mean with random tests, so I changed it now.
    Anyway, contributors are allowed now, so I would be very pleased if you have a look

  • Default User Avatar

    Thank you for your feedback!
    I changed the solution setup. Initially I called class Node but then decided to rename it and changed description and test cases, however, unfortunately, forgot about the setup.

    "storage [...] contains [...] edges of this vertex as values of this vertex." - for example, if storage: {"A": {"B: 500", "C": 300}} it means that point "A" is connected with two point: "B" (distance between them 500) and point "C" (distance is 300). Of course, in this example storage also should contain keys "C" and "B" because since graph is undirected, you can travel both ways. So, the whole property should be {"A": {"B: 500", "C": 300}, "B": {"A": 500}, "C": {"A": 300}}.

    "Should contain method add()" - well, you have got a point here. It is not really required for the solution, but I thought about giving some ideas of how the problem can be solved.

    "Why do you pass 0 as a third argument to findShortestWay?" - I do not require others to do that, so did not mentioned in the description. Personally, I use it to set up the initial value of starting point in Dijkstra, and for recursive call handle this argument in other manner.

    Well, I start the description mentioning about graphs. All the story about cities is just for making the problem description a little lively, because I thought that problem for, lets say, begginners in programming since all experienced developers for sure really keen on graphs, DFS, BFS and so on. So probably for these begginers description containing boring math terms would not be very inspiring, so I desided to make less abstractive and more real life related

    I do not really get a point random test issue. I am sorry that is my first kata, it is open for contribution and if anyone would be so kind to help me make it better, I will very appreciate that.

  • Default User Avatar

    Thank you for your feedback!
    Both added.