Ad
  • Custom User Avatar

    If you could fix assertion messages, this would be approvable.
    I'm also seeing changes to the description in the diff, though I'm seeing the same or varying changes throughout this chain of forks, so I'm not sure which of those you actually applied or not. Maybe give those another once over to ensure only necessary changes are made.

  • Custom User Avatar

    The translation it's forked from didn't pass its tests

  • Custom User Avatar

    Also, this would have been a good opportunity to improve the (missing) assertion messages.

    EDIT: Disregard my comment about the current solution being correct; cargo test uses debug mode, in which case the overflow becomes a runtime error.

    EDIT 2: Disregard my third point. I hadn't realised this is a new translation, I thought it was an update to an existing translation. There is no current solution...

  • Custom User Avatar

    I don't quite see the point of your fork. From what I can tell, all you did is update the reference solution with one that you would consider "more correct". However

    • MIN is never tested
    • The current solution is correct (due to overflow, the result of negating abs of MIN is MIN)
    • This will have no effect other than adding your new solution to the solutions page under your name. You achieve the indentical outcome by simply solving yourself the regular way

    If you can give me a good reason for this fork to exist, I will consider it, otherwise I will simply reject this.