Ad
  • Custom User Avatar

    The description should have included at least one full example for the value of n.

  • Custom User Avatar

    python new test framework is required. updated in this fork

  • Default User Avatar

    Somebody help me. I dont understant what I need to return for empty input.
    Where I can find this information? If your kata can accept empty input, you should describe what function need to return. Hate this stupid Assertion Error.

    AssertionError: combinationLock([[],[],[],[],[],[],[],[],[],[],[]], [135,90,315,225,0,0,315])

  • Custom User Avatar

    Please use new python test framework.

  • Custom User Avatar

    Excellent kata! Except for the fact that it really has nothing to do with combination locks. But I can see where the idea came from. As @docgunthrop pointed out, the description about real combination locks does not really apply to this kata.

    To make it more like a combination lock, I suggest that the 'combinations/rotations' be relative to wherever the dial is in the previous combination, and also include negative (counter-clockwise) rotations. It would only require minor changes to the solutions we already have, but I think it would be worth it to create a realistic scenario.

  • Custom User Avatar

    Some issues to clear up:

    1. To avoid ambiguity, the description needs to make clear if the dial position remains changed after each turn. After checking the test cases, it became apparent that the dial always resets back to its original position before each subsequent turn.
    2. At the beginning of the description where a combination lock is being explained, it would seem to suggest that the rotations alternate, when they actually don't. If you're going to put that description in there, at least clarify that in this kata the rotations will always be clockwise.
    3. (minor issue): The omnidirectional diagram in the description has a typo - the number 235 should be 225.