Great kata! I've been slowly going through the test suite, now around 60 passing...

I noticed a very minor issue, not affecting the coding. In the visual representation of this test:

   CH2
    / \
 H2C   CH2
   \   /
   HC-C
   //  \
   O    COOH

2-oxocyclopentan-1-carboxylic acid = [('C', 6), ('H', 8), ('O', 3)]

The Hydrogen on the bottom of the cycle (on C-2) is on the wrong carbon. It should be on C-1:

   \   /
    C-CH
   //  \
   O    COOH

well that was smart

My brain has yet to reach this level of logic building.

That's... possible. It was the case in the past, yes. I don't know if it got fixed or not. I guess not...

Note for future: create a new translation.

Thanks!

(Although I didn't seem to get any points for it. Do they go to the original translator?)

approved

the expectedSolution method should be private

Done.

the building of the random list of coins is a bit weird (why not directly an array?)

Done. Much simpler.

Not sure exactly what you mean here.

I guess it's just the diff that is not showing the next line (worst case, I can fix it after approval)

• the expectedSolution method should be private
• the building of the random list of coins is a bit weird (why not directly an array?) but at this point, "whatever", I guess.

Poke at me when the method is private.

I think the java code block is missing the closing backticks? (maybe not, it's not clear by looking at the diffs)

Not sure exactly what you mean here.

Why the instane if the method is static...? => remove the instance completely?

That was in the original translation that I forked. I have removed it.

the solution setup is not aligned with the current solution (no static method).

Fixed. Also added final to both parameters.

could we use a loop to write only once the code for assertions?

Done

That's the opposite... The actual problem is the extra s

• I think the java code block is missing the closing backticks? (maybe not, it's not clear by looking at the diffs)
• Why the instane if the method is static...? => remove the instance completely?
• the solution setup is not aligned with the current solution (no static method)
• could we use a loop to write only once the code for assertions?

Duplicate. Changing the language doesn't change the fact there are already a solid bunch of kata about that.
Unpublishing.

Hi,

• the specs are not matching the tests: 'S' should return None while it's supposed to be taken as 's'.
• This has nothing to do with a date parser, this is a time converter.
• why returning None when the value is negative? A negative timedelta makes sense.
• The task as very little interest, and the DateParser class and its methods are totally useless => ?

Cheers

Map Max: Fury Road