Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Great kata! I've been slowly going through the test suite, now around 60 passing...
I noticed a very minor issue, not affecting the coding. In the visual representation of this test:
The Hydrogen on the bottom of the cycle (on C-2) is on the wrong carbon. It should be on C-1:
May I ask You to add this awesome kata for JS)!!!
I passed the first one and I really liked it.
My heart desire more something like this.
Thank You in advance! With all respect!
I have a few inputs regarding the Rust translation. I was unable to properly review it during translation stage, so these come a bit belatedly, but no one has solved yet, so addressing them shouldn't be a problem. Note: I'm going by the sample tests only, so far. I assume the proper tests have the same problems.
Result<_, ChemResult>
instead. This should be "... return aChemResult<_>
instead."unwrap()
on the Result types, which generates an error if the wrong Variant is returned. Instead, the correct variant should be tested itself.Display::fmt
on theAtom
type. If that isn't implemented properly right from the start, then they all fail, making it hard to see whether the other stuff tested in each test fails or not. These should be decoupled.assert_eq
, which outputs its own assertion message in addition to the one you provide, causing a wall of text (especially for longer molecules) and creating redundancy. You getassert!()
or simplypanic!()
) that neatly formats the results and makes them legible.Could someone please do a JavaScript translation of this kata?:)
This comment is hidden because it contains spoiler information about the solution
I think there might be a discrepancy in your numbering of "alkanoyloxy" esters.
Example 1, from the description:
This shows that "propanoyloxy" is like a carboxylic acid, with a =O at C1, which links to the Root via a -O.
Example 2, from the static tests:
Specifically, look at the "15-[1,2,2-triamino]propenanoyloxy" substituent. So:
What am I missing here? Or is there an error?
I have a question about the addChaining method. The description says
As for the add method, this chain is not considered as a new branch of the molecule.
If this is the case what is the chain? You give the example of-C-C-C-Mg-Br
. I'm imagining that bonded to a C at a 90 degree angle. How is this any different from any other branch in the molecule? If it isn't a branch, what makes it not a branch and what makes a branch a branch?