fixed

I'll fix it!

Description changed. I think it's more proper to still have the minimum amount of words needed for any max to be base.

Oh, I thought that even if the max < base you would still have words for the leftovers of the system from a proper understading of the system itself. But you both are right. In the way I defined the problem before it makes more sense your way

Done in above fork

Approved

The reference solution is incorrect. Here is an example: base = 7, max = base ** 3 - 1 = 342. The reference solution returns 10. But the correct answer is 7 + 2 = 9 since max < base ** 3.

Why are there no tests that checks max < base?

There are tests where max < base, but with the wrong result, e.g.:

assert.equal(words(10, 4), 10);

The number of words needed to read numbers up to 4 is 5 (including 0) or 4 (excluding 0), not 10.

Same bug in random tests.

3. Why are there 1 million random tests?

1. Use assert.strictEqual instead of assert.equal
2. Why are there no tests that checks max < base? I think this case should be valid.

.

Approved

Update Fork

• Implementation for the suggestion below
• Tests cleanup (using chai for assertion and tests rewrite)
• Removed the tester(26, 40, 33) test (since it goes against the input constraint)

resolved

Resolved