Ad
  • Custom User Avatar

    btw, plmease use the new version of the test framework, it's WAY more readable... x)

  • Default User Avatar

    Ah, those are actually both great ideas. I think I'll have plenty to fix for now, I'll un-publish it for a now untill I've fixed everything.

    Thanks for the help!

  • Custom User Avatar

    dwonvote: I guess I have to thank henry for that, then...

    Well, about the description, split it in different parts with titles, maybe? (task (overview) / input / output / error handling. Don't forget to give the meaningful info in each part. Like the fact that the notes are ordered "accordingly to a piano", for example ('didn't find a better way to say it... x) ))

    About the notations, There is I believe a simpler and shorter way to do it. Currently you just put the example tests in the description so, even if that's better than nothing, I guess you could just give all the notations (aug, 7, 9, ...) and clearly say that the user will find an example of each of them in the sample tests.

  • Default User Avatar

    It was not me who downvoted you, you are right, and I will correct it in a sec. Thanks for all the advice! This is my first kata, and I was afraid I would make a lot of rookie mistakes. I can certainly use the advice, so thanks!

    I've also rewritten the description (I will add a part about including error handling), do you have any other comments on the description? I found it's pretty difficult to give enough information to someone with no knowledge of music at all, while not being redundant and explaining too much.

  • Custom User Avatar

    you'll understand after some months of seeing beginners raising questions and issues after questions and issues... x/

  • Custom User Avatar

    Though I agree the description is somewhat brief, I think the application of some common sense is suffice to solve this Kata. The task is pretty obvious.

  • Custom User Avatar

    lol... Instead of downvoting me, understand how the design is currently wrong and learn from my comment. If you don't understand how bad it is, read those:

  • Custom User Avatar

    Related to the previous one, but this one is about the implementation rather than the description, so I open a fresh one.

    errors:
    'C!!NO!!' should equal False
    

    Don't ask for different kinds of ouput, that's a very bad design. You don't wanna learn to code that way, and you don't wanna people to see you code that way... :p

    2 ways to handle this:

    1. return a specific string. That's just "not as bad" as the current setup, because you at least keep the kind of output constant, but the better way to handle this is...
    2. throw an error and check in the tests that it's thrown when required (and only then).
  • Custom User Avatar

    what the... X(

    > Errors
    
    • why the hell isn't that told in the description that we have to handle incorrect outputs inputs?
    • what is considered invalid? Not even told!

    That's pretty bad... :(

  • Custom User Avatar

    and you need to tell to the user if you will give all the notes in a specific order or if they may be shuffled (the later won't change the difficulty of the task but that could be a bir more interesting for beginners)

  • Custom User Avatar

    Hi,

    Your description is way too much incomplete.

    • you didn't described the actual exact task
    • it should hold without the external link. If it cannot because there are way too much data, maybe it's the kata itself that should not be?
    • you have to at least give all the notations of the expected output and tell what they are/mean, especially since some of them may be different in the wiki page.
  • Default User Avatar

    I would suggest adding a lot more test cases. Now it's just guessing which words are going to be in, and hardcoding them. If you have hundreds of test case, that isnt possible anymore.

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    that's it. But afaik, you cannot do anything against that (unless you try to spot the problematic statements by parsing the code, or try to redefine all the bad stuff, but it very quickly goes out of hands and mostly is pointless because someone wanting to cheat will always find a way, especially in python).

  • Custom User Avatar
    *************************
    *  MANUAL NOTIFICATION  *
    *       SEE ABOVE       *
    *************************
    
  • Loading more items...