Ad
  • Custom User Avatar

    Modifed Generic Test and added Random Test...
    Kept the handicraftsman's solution!
    But there were description merge conflicts!
    Please, review, and approve...

  • Custom User Avatar

    Great, thanks :)

    I've just removed the C# implemenation from the kata and unchecked "allow contributions"

  • Custom User Avatar

    Hey Shivo,

    I haven't really done anything with C#, so idk what I was thinking closing the last issue. I took a look into what you're saying now, and guess what?

    I see what you mean!

    So, it's kind of strange, because in the code-editor (when creating/editing/publishing the kata), it shows what you would expect public static string[] CapMe(string[] strings) - however, when actually training the kata, it's showing int perhaps jhoffner can comment? I'm not sure how to ping him, but this seems like a bug.

    With regards to the example tests, there's no "issue" per se with them not being present. That's up to the preference of the author of the kata, and if people writing the kata can't figure out expected and actual from the examples given in the description, they may not benefit much from having those example tests anyway.

  • Custom User Avatar

    Has anyone addressed this? Is it an "issue"?

  • Custom User Avatar

    typo is fixed and random tests are added. remove the issue please.

  • Custom User Avatar

    It is worth mentioning that "11" is technically a valid substring of "11" but is excluded from the expected test results. Technically you "11" has [1,1,11] as substrings and all 3 are of course divide cleanly.

    This is already implicit by your example of "11" being 2 in your description but it is probably best to make it explicit with a statement like "the full number does not count as a substring of itself when counting matches."

  • Custom User Avatar

    Ty, will try to do something about that.

  • Custom User Avatar

    Should be fixed now, thanks for the notification and g964 was right :)

  • Custom User Avatar

    I think I maybe found an error in the Python solution. Try Test.assert_equals(substring_test("Codewars is sweet!", "is"), True). The solution and reference solution return False. Maybe look at xrange(0,len(str2)-2). Did you notice Giacomo?

  • Custom User Avatar

    yes, please... I think i'm not able to merge this changes. Sorry for the inconvenience

  • Custom User Avatar

    I'm trying to merge it, but I can't do it because I have changed the description of my kata and yours should have the same description.

  • Custom User Avatar

    Hi Shivo, first of all thank you very much for spend your time translating this kata. I've seen your translation and the approach I thought when I did the kata was a little bit different, (probably I didn't explain it well when I wrote the kata). Noise chars can be only %$&/#·@|º\ª and you must avoid introduce those chars on the message, but others could be part of the message. Your approach is to only accept a-zA-Z and spaces.

  • Custom User Avatar

    Oops... Fixed.

    Thanks :)

  • Custom User Avatar
  • Custom User Avatar

    Yeah, I enjoy these solutions as well!

  • Loading more items...