It's something that came to mind, but for some reason I expect people to be honest when doing these.
Will update them. Means I have to re-implement the methods in the tests to be able to test the returned values are correct, because I don't think a simple decoded !== encoded will suffice, although it might.
Fixed.
The naming is kinda misleading. The
$this->encode()
call is my helper. But I've renamed the other var so it should be easier to read.assertEquals(mixed $expected, mixed $actual[, string $message = ''])
Updated the translations (need approval), and added one for 7.0. Should be what you're asking for.
This is a copy-paste of the 7.4 code.
Fixed. Removed logging that was making it slower.
It's something that came to mind, but for some reason I expect people to be honest when doing these.
Will update them. Means I have to re-implement the methods in the tests to be able to test the returned values are correct, because I don't think a simple
decoded !== encoded
will suffice, although it might.As I said in your review, the tests are the same as the original ones. An example or explanation would be useful.
PHP 7.0
PHP 7.4
Do tell when you've looked again. I guess you simply missed them.
Hmm. Aren't sample tests there for the user to check his implementation? :)
Actual tests have random strings and random rails number.
Look for
testRandom()
in test cases.PHP Translation awaiting approval.
Really good kata.