Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Fixed.
The naming is kinda misleading. The
$this->encode()call is my helper. But I've renamed the other var so it should be easier to read.assertEquals(mixed $expected, mixed $actual[, string $message = ''])Updated the translations (need approval), and added one for 7.0. Should be what you're asking for.
This is a copy-paste of the 7.4 code.
Fixed. Removed logging that was making it slower.
It's something that came to mind, but for some reason I expect people to be honest when doing these.
Will update them. Means I have to re-implement the methods in the tests to be able to test the returned values are correct, because I don't think a simple
decoded !== encodedwill suffice, although it might.The issue is this: A user can bypass the fixed tests manually, and then for the random tests, just return the input. You need to actually check the result of the encoding/decoding for random tests, not just encode then decode--because you're not actually forcing them to do it.
As I said in your review, the tests are the same as the original ones. An example or explanation would be useful.
PHP 7.0
PHP 7.4
Do tell when you've looked again. I guess you simply missed them.
Hmm. Aren't sample tests there for the user to check his implementation? :)
Actual tests have random strings and random rails number.
Look for
testRandom()in test cases.The tests can be easily cheated.
PHP Translation awaiting approval.
Really good kata.