Ad
  • Custom User Avatar

    Rejected:

    • No random tests

    • All tests always pass because the actual function is not tested against

    • Actual and expected are swapped

    • Outdated PHP version

    • Missing <?php and <?php use PHPUnit\Framework\TestCase;

  • Custom User Avatar

    Rejected:

    • No random tests

    • Should've used assertEquals for better error output

    • No need to throw Exception in solution

    • missing static declaration for initial solution setup

  • Custom User Avatar

    Adjusted, thanks!

  • Custom User Avatar

    Look at the argument order in the random tests.

    The fixed tests are fine, it's the random tests that still do it wrong.

  • Custom User Avatar

    Same of the previous comment:

    User answered with 2000

    Right answer: 1

    System says: "2000 should equal 1"

    If I invert the order result in a wrong answer:

    1 should equal 2000. No, should equal 1.

    I think I did not understand the problem.

    You have 90K (kyu). I think you have the privilege to edit the kata. If you do this, please explain your change.

    Or please help me to understand better.

    Thanks

  • Custom User Avatar

    No, not OK.

    Argument order is still wrong in random tests.

  • Custom User Avatar

    It's in the Example tests as well, but to see that you may have to refresh if you opened the trainer earlier.

  • Custom User Avatar

    Adjusted. Seems ok in the tests, but I did the same changes in the example tests and the changes was not exhibited in the example tests :(

  • Custom User Avatar

    About the order, please see the message returned:

    "20000 should equal 1"

    I forced the function in my solution testing the kata (I am changing the user solution, not the kata) to return 2000. In this case the message returned looks like ok, right?

    Message returned: "20000 should equal 1"

    2000 -> what user returned
    should equal 1 (1 is the right answer).

    Ok, right?

  • Custom User Avatar

    this link is locked to me

  • Custom User Avatar

    thanks, I will try to adjust when I arrive home

  • Custom User Avatar

    thanks, I will try to adjust when I arrive home

  • Custom User Avatar

    Off-topic, but let me know your opinion about this.

    We have been receiving a lot of complaints.

  • Custom User Avatar

    Yup :)

  • Custom User Avatar

    Also, generating inputs from expected values is generally preferred over using a reference solution. In this case, it's possible ( see below ), it's faster, and it's also more readable ( and a lot shorter ) than your reference solution.

    Consider doing that.

  • Loading more items...