Yes, that's what it should return, the elements of a2 sorted following a rule on the elements of a1. Not a kata issue.

I have tried solving this based on the description but it is so misleading. And the function seems to return the sorted elementes of a2 all the time.

Approved the fork!

Fork cleaning things up

because of this code i now understand what this codes do unlike from the first one it is readable for beginners like me

yess

This is just a warning, the kata still works.

Somebody needs to fix this

STDERR
assertSimilar is deprecated, use assert.deepEqual

There are already random tests.

mmmh... Then the issue is:

• you should split the test suite so that the kind of tests is clearer (describe/it blocks)
• you need to make more random tests, just one (apparently) isn't enough. => use a loop and make like 50 of them, for example

cheers

I've updated the description as I agree your suggestion explains more clearly what's required.

There are already random tests.

the description of the task is at least misleading, but I rather considere it incorrect. What the user is asked for is actually:

Given two arrays, a1 and a2, sort the elements of a2 based on the the index of the word in a1 that begins with the same letter.

And: needs random tests.

How is mutating the input a best practice?

Oops, fixed :)

You've written a2 instead of a1 at the end of the first sentence.

I've updated the description so hopefully it makes things clearer.