Ad
  • Custom User Avatar

    I meant no attack on you personally, Azuaron (or the other warriors who completed with this code). I applaude your ability to write something in a consise mannor that solves the problem. However, I do not believe this solution best represents the term "Best Practice". It is clever, but a solution that I would consider "Best Practice" would also clearly convey the intent of what the code is accomplishing.

    Emotion is hard to convey over text, and I assure you that my words in the previous post carried no malice with them. Thank you for your reply, and in future posts I will be sure to convey my opinions more clearly.

  • Custom User Avatar

    Not best practice. Imagine trying to read this function with no context of the problem it was trying to solve. What does p stand for? How how about aug? Consider changing the argument names at least to something more readable.

    I would also agree with @weejo on the argument mutation problem of this solution.

  • Custom User Avatar

    The Ruby version needs updating. It gives code as a starting point, and gives away another solution in the test file.

  • Custom User Avatar

    @JavierHeisecke my pleasure! And @Chrono79 I will keep that in mind, thank you. What is the edicate here on spoilers, then?

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution