Ad
  • Custom User Avatar

    First define Clean code in a small context.

    The context is all.

    Is a test? A MVP? An architecture? or merelly a beginner kata?

    A pragmatic programmer who applies Clean code also balances:

    • designing/coding spent time
    • readability
    • available time and money cost
  • Custom User Avatar

    I agree that this isn't best practice, though it is a decent solution. For instance, I wouldn't want the arguments to be changed in the function body as it leads questions about accidental mutation (particularly if you come from another language). Of course, the argument names are bad, but as they are given by the Kata I can understand keeping them the same. However y to stand as number of years is a poor choice. With modern IDEs, there's very little reason to not use descriptive variable names. So if this was a professional codebase, I would want some changes before I would accept this.

    But definitely a good solution in terms of solving the problem

  • Default User Avatar

    If you want to make it more readable you can always customise the arguments yourself.

  • Custom User Avatar
  • Default User Avatar

    I agree with chandlerroth, this is a brilliant and concise solution but readability / reusability is terrible.

  • Custom User Avatar

    I do agree with chandlerroth here, I don't think he meant to be insulting in any way. This code, if come across in an actual code base, would stop me in my tracks and would demand refactoring or renaming. I am new here, so I am not exactly sure what the target is here at codewars but I don't see how so many people find this solution as "best practice".

  • Custom User Avatar

    Imagine walking up to someone, opening your remarks by saying their code's bad, then expecting them to listen to anything you had to say.