Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
I think this should be considered as 7 kyu.
The tests are unacceptable: a lot of methods aren't tested, and there are only the most basic fixed tests (which 99% of is "is this class/prop/method defined" and "is something instance of a specific class").
There are no random tests either.
I am not very experienced with Python and may be mistaken, in Python they don't usually have private fields. At least from the materials I read and the code I saw. Unlike Java for example where encapsulation is essential. Or is this just because most people write bad Python code :D
fun kata, not sure whether this kata would be considered a duplicate: https://www.codewars.com/kata/5808ff71c7cfa1c6aa00006d
yours asks for word counts, that one char counts, so probably good
Unpublishing as a duplicate of https://www.codewars.com/kata/526c7363236867513f0005ca/
This comment is hidden because it contains spoiler information about the solution
Typo in the sample tests: "Lamp getter method..." instead of "Lamp setter method..." under "// test setters"
( JS, possibly others )
Nothing is apparently being done with the colour of the lamp. I suppose there are tests, but it feels unsatisfying.
Prescribing the internal representation for
on
is not good. That implementation detail could, and therefore should, be hidden and up to the programmer.Marking this as a suggestion three and a half years late would not be very useful though.
Not an issue.
If this is intended to be a beginner-level kata, perhaps the instructions/requirements could be more explicit about the constructor (order of params?) and getters/setters (method names?). New programmers may not have learned the conventions for getting and setting.
add TODO: Give the lamp an instance method called toggle_switch that will switch the value of the on attribute.
Groovy translation kumited. Please review and approve. Thanks, suic
JavaScript and TypeScript translations.
Loading more items...