Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
The tests are unacceptable: a lot of methods aren't tested, and there are only the most basic fixed tests (which 99% of is "is this class/prop/method defined" and "is something instance of a specific class").
There are no random tests either.
This comment is hidden because it contains spoiler information about the solution
Typo in the sample tests: "Lamp getter method..." instead of "Lamp setter method..." under "// test setters"
If this is intended to be a beginner-level kata, perhaps the instructions/requirements could be more explicit about the constructor (order of params?) and getters/setters (method names?). New programmers may not have learned the conventions for getting and setting.
Javascript translation sent! Please review and publish it :)
Cheers!
Maybe provide some edge-cases with words like "aren't"/"isn't" to see the different behaviour of
String#split
andString#scan
. I hope I am not totally wrong, butString#scan
would split "aren't" into "aren" and "t"?The information about the difference between the correct result and user answer would be helpful. You could also provide a function skeleton and not force the user to write it by himself.
Needs random test cases
The wording for the definition of a leap year is confusing. Suggest changing to “A year is known as a leap year if the year meets one of the following conditions:” or something similar.
There is no test case for intialising state to anything but "on"
Needs some random test cases.
Duplicate:
http://www.codewars.com/kata/leap-years
http://www.codewars.com/kata/leap-year