Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Suggest to remove the
map
recommendation in C language Kata Description.In the sample tests for C language**, the below needs fixing as it's actually an invalid input and should be returned as false.
This can cause confusion as in the attempt test cases it should be false.
cr_assert_eq(valid_phone_number("(123)456-7890"), true);
Language: C
Error messages are unclear.
The expression (one(((void*)0), 0, &always_true)) == (0) is false.
As a 7kyu kata, I Suggest fixing error messages for clearer understanding of the errors.
Fixed Cases attempt tests in this;
The expression (duplicate_count("abcdeaB")) == (2) is false.
I suggest changing this error message to
expected: , submitted:
as it is in the random tests error messagesYou're kinda right, it can be a little throw off, but, if you focus more on what the task is asking for, it'll make more sense.
stderr when sample tests run, 9 errors of unused** variables in the sample tests.
I'm surprised to see
strrev()
in the solution worked, since strrev is not standard!This comment is hidden because it contains spoiler information about the solution
My Apologies, in C
Test cases
When infact the Kata test considers this as invalid. The error message says it's Valid and causes confusion. The error message should read either:
or
Or something like that, In my Opinion
The asserts for "Test" also need changing!
Thanks!
Error message is somewhat unclear. Though I understand it, it's only due to a previous confusion with a previous kata that I sought help for. Maybe wording it a little clearer for fresh coders.
I feel this error message should be modified to be made more clear.
Thank you! I see where I went wrong! Thanks!
Function works perfectly, it can pass the tests, but on last few tests, it times out. Should there be a limit set to array sizes?