Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
done
Suggest to remove the
map
recommendation in C language Kata Description.someone fixed it apparently
i also added more sample tests as tehre was only one
fixed
Fixed C example tests.
Regarding the sample tests and test attempts for the bash solutions: there is no testing if there are any non-numericals on spots in the string that are reversed for for numbers. In bash at least. My script only tests: length of phone number and if the special characters are placed correctly.
In the sample tests for C language**, the below needs fixing as it's actually an invalid input and should be returned as false.
This can cause confusion as in the attempt test cases it should be false.
cr_assert_eq(valid_phone_number("(123)456-7890"), true);
Language: C
Error messages are unclear.
The expression (one(((void*)0), 0, &always_true)) == (0) is false.
As a 7kyu kata, I Suggest fixing error messages for clearer understanding of the errors.
I see I assummed I was nit just counting the number of characters that repeat, but also the number od times I assumed that was somewhat implicit my bad.
I shoukd be able to easily fix this.
My code logic was wrong.....
The test is ok, your code is not. The expected result is ok, there are 3 repeated letters,
a
,b
andc
, it doesn't matter how many times each letter is repeated.Thanks, I've just now put the
Submitted
before theExpected
in the random tests, being the expected order for this language.Fixed Cases attempt tests in this;
The expression (duplicate_count("abcdeaB")) == (2) is false.
I suggest changing this error message to
expected: , submitted:
as it is in the random tests error messagesYou're kinda right, it can be a little throw off, but, if you focus more on what the task is asking for, it'll make more sense.
stderr when sample tests run, 9 errors of unused** variables in the sample tests.
I'm surprised to see
strrev()
in the solution worked, since strrev is not standard!Loading more items...