Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Fair enough. When I have a moment in the next few days I'll make changes following this and the other comments, and I'll see which cases fit better in the tests vs which ones might be better ruled out in a spec.
Okay, sounds good. I took the "and" out of the example with the three guys, which was a mistake. They should be all simply comma-separated, and I don't want to have to worry about "and" or "&" or Oxford comma or not.
I added notes in the description to narrow some of these questions, and I'll add some more test cases. Would you be okay if I copied yours from this post above?
I wanted to use real movies, and to have the random tests generate only the kinds of cases that came up in the real-world examples. But maybe that's just me being silly.
I'll check it out, thanks
Great kata. One tiny stumbling block for me was that the init assigns to self._parts, but then the tests look at self.parts. I assumed they'd be checking for immutability on the underscored version. (Or maybe they're hinting that we should keep both separately...)
Map Max: Fury Road
This is a good one for testing performance but not too harshly
oops, i left the import in there
This could be an interesting pattern-matching problem, but right now it's just a trick about whether you read the order of two very similar words
I also saw the
don't import ast or a module that depends on it
message when I hadn't imported anything. In fact, you can reproduce this in one line by writingreturn x
and getting a NameError because there is no x. So there must be something that wrongly triggers that message with Python NameErrors, at least.Why do you say that?
This comment is hidden because it contains spoiler information about the solution
You can avoid this now with the walrus operator
Looks good to me. However, I tried to approve and got
Failed to approve: translation must be pending over a week or the kata author must be inactive for the past month
While we're changing things, how about the parameter names?
list_of_art
is especially mysterious, with nothing in the problem that seems to fit the "art" abbreviationLoading more items...