Ad
  • Custom User Avatar

    Found the problem. @docgunthrop, could you approve again pleaseeeeeee, sorry!

  • Custom User Avatar

    :(. I'll have a look!

  • Custom User Avatar

    This issue sould be resolved now.

  • Custom User Avatar

    Cool, done. @docgunthrop, care to do the honors?

  • Custom User Avatar

    Hmmm, the only thing I can fork is my current translation, as in the one I linked above. I'm guessing this will produce the same problem?

    I can't create a new Java translation either, and I see no other way to fork the Kata.

    Any ideas @Blind4Basics?

  • Custom User Avatar

    I've re-submitted it. Can you try again?

  • Custom User Avatar

    Work pass fix can you approve @docgunthrop?

    I'll have to look int the test per day we talked about another time as I don't have much time at the moment :(

  • Custom User Avatar

    Hmm, the only buttons I have there are 'Add to Collection' and 'Share this kata' :(

  • Custom User Avatar

    I haven't made the changes yet, just in the process of updating it locally.

    Also, unless I'm being dumb, I dont have the ability to directly edit the Kata, only fork it and request and approval :(

  • Custom User Avatar

    Ok, I figured out the problem, I'm just not checking work pass expiry in my tests 🙈.

    I also found the unchecked operation, which I thought I'd fixed previously but obviously not.

    I'll also update to using parametized tests with one test per day as per your prevous suggestion.

    With regards to the ID_Card, my translation follows the original solution, plus it also sort of follows the original game, ID_Cards are for Arstotzka citizens only.

    Errr... But just look at the data: my answer(s) is(are) valid but is(are) rejected by your tests! x)

    Also, sorry, I wasn't trying to be hostile, was just giving a quick response before I looked into it properly :D

  • Custom User Avatar

    I'll have a look into the one test per day.

    With regards to the tests, if there are mutliple failures, as long as your solution matches one then it will pass, taking into account the order of priority for failures.

  • Custom User Avatar

    ID Cards are for Arstotzka citizens only, so non-foreigners. So, if anything the tests would assume that the entrant isn't a foreigner, although, I believe nationality is only determined when a passport is present. Correct me if I'm wrong @docgunthrop.

  • Custom User Avatar

    C# translation added! Hopefully this one doesn't have as many problems ^.^

  • Custom User Avatar

    Hi @docgunthrop,

    Sorry to be a pain again, I made the changes that me and Blind4basics were discussing, could you approve the translation again?
    https://www.codewars.com/kumite/5bac99159842ccfcf90004d5?sel=5badf8ec528b29a07f000132

  • Custom User Avatar

    Actually, having thought about it I think you're right, I will re-work it to closer match the original solution using HashMaps. For now, I'll document the classes in the description then update it when I'm done.

  • Loading more items...