has been approved

Hi @joesmith100,

Can you please fix the C# translation.

There is bug for empty input (reported in the recent discourse)

Currently the test case look like below (which conflicts the Kata description and my original Java Kata)

    [Test]
    public void EmpytyZoo()
    {
        string input = "";
        string[] expected = {
          "",
        };
        
        Assert.AreEqual(expected, Dinglemouse.WhoEatsWho(input));
    }

But it should look like this (and your solution to change accordingly)

    [Test]
    public void EmptyZoo() // DM - FIXED TYPO
    {
        string input = "";
        string[] expected = {
          "",
          "" // DM - ADDED THIS
        };
        
        Assert.AreEqual(expected, Dinglemouse.WhoEatsWho(input));
    }

I think there's a mistake in the C# version. In line three there's the class Simplexer : Iterator but I think it should be class Simplexer : IEnumerable. Am I correct?

It's approved now.

no you cannot publish a brand new java version because one already exists, so you have to fork the current/last translation, then update the full description from scratch: meaning: you open a new tab where you create a new translation, whatever the language is, then you copy the full description and paste it in the fork of your translation. then, update what's needed and pulish.

it needs a new fork, actually. Won't work otherwise.

I keep getting the same message though I haven't made any changes.

Description cannot be approved, recent changes from related record must be merged first.

@joesmith100 I get the following message when attempting to approve:

Description cannot be approved, recent changes from related record must be merged first.

Maybe try to resubmit?

so, where is that Java fix??? :o (still the workpass issue pending)

ok, resolving here: apart from the work pass problem, all seems good.

@joesmith100 I'm not sure what else I can do about your ability to edit the translation; I've already set the kata to allow contributors. If you need to make a revision, I guess you can just post a comment and I'll try to get it approved quickly.

@B4B There are two types of documents that don't include an entrant's nation: the ID card and certificate of vaccination. I had added the detail about the ID card in the Description yesterday and I've now just added instructions regarding the certificate of vaccination.

Ah ok.

Mmmmh, about the fork/edition, with more than 4000 honor, you should now be able to access the edit panel. Check in the upper right corner if you see the "edit kata" button next to the "add to collections" one.

no problem ;)

Did you do the changes directly in the edit panel? Or is it a fork that Doc has to approve? Because I currently still get the old test suite in the trainer (even after a refresh/reset), with the same work pass trouble.

@Doc: about the absence of nationality in the docs, since anter69 talked about it too, maybe you could put a clear rule about it in the description? (I looked at my python solution and effectively used a default value for it. I didn't pay attention to that at the moment because I was dealing with the other stuff, then)

Hi @joesmith100, I had made a tiny change to the Description and now I can't approve your translation. Would you mind resubmitting your translation?

oh, btw: there is a warning that is coming from your code:

STDERR
Note: /workspace/java/src/SolutionTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

That's not a "problem", but that's not really appealing for the user. ;) Could you add the needed "checks"?